[wpilibc] SysIdRoutineLog: Initialize m_stateInitialized #6359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be cleaner to do |
|
You should revert the change to the .cpp file. |
Fixes the m_stateInitialized not being initialized which causes non deterministic behavior as to if the `sysid-test-state-` will appear in the log.
|
Yes, sorry I was doing it all in the github interface. I couldn't figure out how to revert so I had to clone it then revert, squash. I think it's good now. |
PeterJohnson
approved these changes
Feb 10, 2024
PeterJohnson
changed the title
PeterJohnson
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the m_stateInitialized not being initialized which causes non deterministic behavior as to if the
sysid-test-state-will appear in the log.