Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Device Simulation article #1077

Merged
merged 20 commits into from
Mar 19, 2021
Merged

Add Device Simulation article #1077

merged 20 commits into from
Mar 19, 2021

Conversation

Starlight220
Copy link
Member

Fixes #704

Even though this is relatively far from finished, feel free to comment.

I might need some help with the C++ part (both example code and function/class/object/pointer setups).

@Starlight220
Copy link
Member Author

Starlight220 commented Feb 7, 2021 •
edited
Loading

I'll clean up the format/structure later. Anything about the content?
@PeterJohnson is the Sim API used/explained correctly?
@calcmogul can you help me with the C++ stuff?

@Starlight220 Starlight220 marked this pull request as ready for review February 7, 2021 10:26
@Starlight220
Copy link
Member Author

I see that most issues are relevant to the SimDevice API article, which is WIP anyway. I think that I'll split the unit testing article to a different PR, and I'll clean up the SimDevice stuff later. The SimDevice stuff is actually changing relatively fast, as both REV and CTRE are still working out bugs and releasing new interfaces.

@Starlight220 Starlight220 mentioned this pull request Feb 7, 2021
Merged
@Starlight220
Copy link
Member Author

Starlight220 commented Feb 21, 2021 •
edited
Loading

Depends on wpilibsuite/allwpilib#3186's release and #1203.

@Starlight220 Starlight220 changed the title Add SimDevice API article Document Sim APIs Feb 27, 2021
@Starlight220 Starlight220 mentioned this pull request Feb 27, 2021
Open
@Starlight220
Copy link
Member Author

Starlight220 commented Mar 7, 2021 •
edited
Loading

@PeterJohnson is everything here correct? I've used the Java APIs but not the C++ ones. Also, is the warning I added about C++ auto-destruction correct? Is the C++ lambda right?

@Starlight220 Starlight220 changed the title Document Sim APIs Add Device Simulation article Mar 10, 2021
@Starlight220 @Daltz333
Update source/docs/software/wpilib-tools/robot-simulation/device-sim.rst
5fde743 
Co-authored-by: Dalton Smith <daltzsmith@gmail.com>
@Daltz333
Copy link
Member

Some spelling issues.

@Daltz333 Daltz333 merged commit 77c1d4e into wpilibsuite:master Mar 19, 2021
TheTripleV pushed a commit to TheTripleV/frc-docs that referenced this pull request Apr 9, 2021
@Starlight220 @Daltz333 @TheTripleV
Add Device Simulation article (wpilibsuite#1077)
c834835 
Co-authored-by: Dalton Smith <daltzsmith@gmail.com>
@Starlight220 Starlight220 deleted the simdocs branch April 26, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daltz333 Daltz333 Daltz333 approved these changes

@prateekma prateekma Awaiting requested review from prateekma

Assignees
No one assigned
Labels
Type: New Article
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documenting/Tutorial of Sim is needed
3 participants
@Starlight220 @Daltz333 @prateekma