Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http (fix, breaking): RPCContext.current.getThreadLocal interface change to avoid unsafe type cast #3548

Merged
merged 6 commits into from
May 31, 2024

Conversation

xerial
Copy link
Member

@xerial xerial commented May 31, 2024

  • Breaking change: RPCContext.current.getThreadLocal[A](key: String): A -> RPCContext.current.getThreadLocal(key: String): Any to avoid type cast error
  • Also, fixed a bug of getting the previous thread-local values

…ange to avoid unsafe type cast

Fixed a bug of getting the previous context value
@github-actions github-actions bot added bug doc Documentation task labels May 31, 2024
@xerial xerial enabled auto-merge (squash) May 31, 2024 04:33
@xerial xerial changed the title netty (fix, breaking): RPCContext.current.getThreadLocal interface change to avoid unsafe type cast http (fix, breaking): RPCContext.current.getThreadLocal interface change to avoid unsafe type cast May 31, 2024
@xerial xerial disabled auto-merge May 31, 2024 04:45
@xerial xerial added the breaking Breaking changes label May 31, 2024
@xerial xerial merged commit f3aaaa5 into main May 31, 2024
16 checks passed
@xerial xerial deleted the tls-fix branch May 31, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes bug doc Documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant