Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#857 - prevent deprecation warnings shown in all admin pages #858

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpahullo
Copy link

Description

  • When a Moodle site has $CFG->debugusers, Moodle core considers these users as with forced debugging. As a consequence, having this plugin installed on the Moodle, and having $CFG->debugusers with some users, these users will see deprecation messages from any event on every admin pages (i.e., any page below Administration menu).
  • In the same way that Moodle core tries to prevent deprecation messages while calculating the list of events, we propose to backup the value $CFG->debugusers before calculating the list of events, and re-assigning them after this calculation.
  • We believe this patch is appropiate for this plugin, since this plugin being installed is what makes the deprecation messages being shown in all and every admin pages for those $CFG->debugusers.

Related Issues

PR Type

  • Fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant