Skip to content

Commit

Permalink
[dotnet][msbuild] Copy dylibs for macOS and Mac Catalyst (#11226)
Browse files Browse the repository at this point in the history
Fix crash for monotouch-test running on macOS / dotnet

Fix https://github.com/xamarin/maccore/issues/2413
  • Loading branch information
spouliot committed Apr 16, 2021
1 parent bc24d3b commit 7926009
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dotnet/targets/Xamarin.Shared.Sdk.targets
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@
<ResolvedFileToPublish
Update="@(ResolvedFileToPublish)"
RelativePath="$([MSBuild]::MakeRelative($(MSBuildProjectDirectory)$(PublishDir),$(_DylibPublishDir)))\%(Filename)%(Extension)"
Condition="'$(_SdkIsSimulator)' != 'false' And '%(Extension)' == '.dylib'" />
Condition="('$(_SdkIsSimulator)' != 'false' Or '$(_PlatformName)' == 'macOS' Or '$(_PlatformName)' == 'MacCatalyst') And '%(Extension)' == '.dylib'" />
<ResolvedFileToPublish
Update="@(ResolvedFileToPublish)"
RelativePath="$([MSBuild]::MakeRelative($(MSBuildProjectDirectory)$(PublishDir),$(_AssemblyPublishDir)))%(Filename)%(Extension)"
Expand Down

1 comment on commit 7926009

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

Packages generated

View packages

Test results

1 tests failed, 181 tests passed.

Failed tests

  • introspection/watchOS 32-bits - simulator/Debug (watchOS 5.0): LaunchFailure

Pipeline on Agent XAMBOT-1033'
[dotnet][msbuild] Copy dylibs for macOS and Mac Catalyst (#11226)

Please sign in to comment.