Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET NSAutoreleasePool for every thread pool work item #11750

Closed
rolfbjarne opened this issue May 31, 2021 · 0 comments · Fixed by #12060
Closed

.NET NSAutoreleasePool for every thread pool work item #11750

rolfbjarne opened this issue May 31, 2021 · 0 comments · Fixed by #12060
Assignees
@rolfbjarne
Labels
dotnet An issue or pull request related to .NET (6) dotnet-pri0 .NET 6: required for stable release feature A feature to be implemented
Milestone
.NET 6

Comments

@rolfbjarne
Copy link
Member

rolfbjarne commented May 31, 2021 •
edited
Loading

.NET has support for an NSAutoreleasePool for thread pool work items (dotnet/runtime#47592), but it looks like this needs to be enabled (for both MonoVM and CoreCLR).

This issue is to track the required work in our own code.

Related test:

xamarin-macios/tests/monotouch-test/ObjCRuntime/RuntimeTest.cs

Lines 458 to 462 in 165941e

[Test]
#if NET
[Ignore ("https://github.com/dotnet/runtime/issues/32543")]
#endif
public void NSAutoreleasePoolInThreadPool ()

Depends on: dotnet/sdk#18000 #11852
Depends on: #11745.

Ref: dotnet/designs#197 (comment)
Ref: dotnet/designs#197 (comment)
Ref: dotnet/runtime#52023
@rolfbjarne rolfbjarne added dotnet An issue or pull request related to .NET (6) dotnet-pri0 .NET 6: required for stable release feature A feature to be implemented labels May 31, 2021
@rolfbjarne rolfbjarne added this to the .NET 6 milestone May 31, 2021
@rolfbjarne rolfbjarne self-assigned this May 31, 2021
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Jul 1, 2021
@rolfbjarne
[dotnet] Enable autorelease pools for threadpools. Fixes xamarin#11750.
9fafca6 
Fixes xamarin#11750.
@rolfbjarne rolfbjarne mentioned this issue Jul 1, 2021
Merged
rolfbjarne added a commit that referenced this issue Jul 20, 2021
@rolfbjarne
[dotnet] Enable autorelease pools for threadpools. Fixes #11750. (#12060
3c38f8c 
)

Fixes #11750.
vs-mobiletools-engineering-service2 pushed a commit to vs-mobiletools-engineering-service2/xamarin-macios that referenced this issue Jul 20, 2021
@rolfbjarne
[dotnet] Enable autorelease pools for threadpools. Fixes xamarin#11750.
5d8eb73 
Fixes xamarin#11750.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Jul 20, 2021
@rolfbjarne
[dotnet] Enable autorelease pools for threadpools. Fixes xamarin#11750.…
55502bf 
… (xamarin#12060)

Fixes xamarin#11750.
@rolfbjarne rolfbjarne mentioned this issue Jul 20, 2021
Merged
rolfbjarne added a commit that referenced this issue Jul 21, 2021
@rolfbjarne
[dotnet] Enable autorelease pools for threadpools. Fixes #11750. (#12060
eced807 
) (#12149)

Fixes #11750.
@ghost ghost locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rolfbjarne rolfbjarne

Labels
dotnet An issue or pull request related to .NET (6) dotnet-pri0 .NET 6: required for stable release feature A feature to be implemented
Projects
None yet
Milestone
.NET 6
Development

Successfully merging a pull request may close this issue.

[dotnet] Enable autorelease pools for threadpools. Fixes #11750. rolfbjarne/xamarin-macios
1 participant
@rolfbjarne