[tools] Disable Objective-C exception handling for macOS .NET apps due to a missing feature in the runtime. #10123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to a missing feature in the runtime. We need support for dllmaps, and that isn't working on macOS yet.
rolfbjarne
added
not-notes-worthy
61 tasks
spouliot
approved these changes
Nov 20, 2020
spouliot
reviewed
Nov 20, 2020
tools/common/Target.cs
Outdated
| @@ -572,7 +572,7 @@ void GenerateMacMain (StringWriter sw) | |||
| } | |||
| if (!App.IsDefaultMarshalManagedExceptionMode) | |||
| sw.WriteLine ("\txamarin_marshal_managed_exception_mode = MarshalManagedExceptionMode{0};", App.MarshalManagedExceptions); | |||
| sw.WriteLine ("\txamarin_marshal_objectivec_exception_mode = MarshalObjectiveCExceptionMode{0};", App.MarshalObjectiveCExceptions); | |||
| sw.WriteLine ("\txamarin_marshal_objectivec_exception_mode = MarshalObjectiveCExceptionMode{0};", "Disable" /* https://github.com/dotnet/runtime/issues/43204 App.MarshalObjectiveCExceptions */); | |||
There was a problem hiding this comment.
is that code limited to net6 nugets ?
or is it used by XM packages ?
|
Build failure ✅ Provisioning succeeded |
spouliot
approved these changes
Nov 20, 2020
dalexsoto
approved these changes
Nov 20, 2020
mandel-macaque
approved these changes
Nov 20, 2020
tj-devel709
approved these changes
Nov 20, 2020
|
Build success |
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Mar 22, 2021
… apps due to a missing feature in the runtime. (xamarin#10123)" This reverts commit 75979ca.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need support for dllmaps, and that isn't working on macOS yet.