[dotnet][msbuild] Fix RelativePath inside ResolvedFileToPublish #11173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This worked fine up to P3 but failed with an early bump [1] to P4 where paths became invalid (missing a `/`) like: `bin/iPhoneSimulator/Debug/net6.0-ios/iossimulator-x64/publish/../dont link.applibxamarin-dotnet-debug.dylib` and did not copy the required `.dylib` [2] (and other stuff) inside the app bundle. [1] xamarin#11127 [2] .dylib where the first thing to crash at startup ``` Termination Reason: DYLD, [0x1] Library missing Application Specific Information: dyld: launch, loading dependent libraries DYLD_SHARED_CACHE_DIR=/Users/builder/Library/Developer/CoreSimulator/Caches/dyld/19G2021/com.apple.CoreSimulator.SimRuntime.iOS-14-4.18D46 DYLD_ROOT_PATH=/Applications/Xcode_12.4.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot DYLD_FALLBACK_FRAMEWORK_PATH=/Applications/Xcode_12.4.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks DYLD_FALLBACK_LIBRARY_PATH=/Applications/Xcode_12.4.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/usr/lib Dyld Error Message: dyld: Using shared cache: C11E5D38-A0B0-37FA-AECD-28B337F6C0CA Library not loaded: @rpath/libxamarin-dotnet-debug.dylib Referenced from: /Users/USER/Library/Developer/CoreSimulator/Devices/B3F9E3AC-227F-4B66-9F12-76C5B2CE4E34/data/Containers/Bundle/Application/379106D5-912C-47CC-A0E5-446C7C524706/dont link.app/dont link Reason: image not found ```
dalexsoto
approved these changes
Apr 9, 2021
✅ Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diff🎉 All 94 tests passed 🎉Pipeline on Agent XAMBOT-1093.Catalina |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This worked fine up to P3 but failed with an early bump [1] to P4
where paths became invalid (missing a
/) like:bin/iPhoneSimulator/Debug/net6.0-ios/iossimulator-x64/publish/../dont link.applibxamarin-dotnet-debug.dyliband did not copy the required
.dylib[2] (and other stuff) inside theapp bundle.
[1] #11127
[2] .dylib where the first thing to crash at startup