[tests] Adjust resources test to cope with the fact that only the invariant culture is currently shipping in .NET 5. #9498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ariant culture is currently shipping in .NET 5. Ref: xamarin#8906 This is the third of three steps to fix this test failure: EmbeddedResources.ResourcesTest [FAIL] Embedded : en-AU Expected string length 5 but was 7. Strings differ at index 0. Expected: "G'day" But was: "Welcome" -----------^ at EmbeddedResources.ResourcesTest.Embedded() in [...]/xamarin-macios/tests/EmbeddedResources/ResourcesTest.cs:line 45
spouliot
approved these changes
Aug 25, 2020
61 tasks
dalexsoto
approved these changes
Aug 25, 2020
|
Build failure Test results16 tests failed, 70 tests passed.Failed tests
|
|
build |
|
Build success |
spouliot
added a commit
to spouliot/xamarin-macios
that referenced
this pull request
Apr 8, 2021
… the invariant culture is currently shipping in .NET 5. (xamarin#9498)" This reverts commit 6a1e8ac.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #8906
This is the third of three steps to fix this test failure: