Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-49900: Removed templates folder from python3/ #5800

Merged

Conversation

ashwin9390
Copy link
Contributor

Main ticket CP-49100 :Move python3 scripts from scripts directory to python3 directory.

Sub task CP-49900
-This PR makes changes to #5758
-It was decided we can remove templates directory as it is not used in Dom0

  • Removed templates debian and debug from Makefile
  • ocaml Smoketest did not throw any error.

Signed-off-by: Ashwinh ashwin.h@cloud.com

- Removed templates debian and debug from Makefile

Signed-off-by: Ashwinh <ashwin.h@cloud.com>
@psafont
Copy link
Member

psafont commented Jul 10, 2024

This must have a corresponding xapi.spec change for the feature/py3 branch @liulinC

@liulinC
Copy link
Collaborator

liulinC commented Jul 11, 2024

This must have a corresponding xapi.spec change for the feature/py3 branch @liulinC

yes,
@ashwin9390 the spec repo and branch needs to be update to make sure the rpm build does not break. We need to run enough XenRT test before feature merge back to master. (and remove this file from spec file). cc @stephenchengCloud

This PR looks good to me if we are sure the removed python scripts no longer necessary. cc @xihuan-citrix

Copy link
Collaborator

@liulinC liulinC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good by itself,

@stephenchengCloud Please prepare a feature branch with this update so @ashwin9390 can do rpm/XenRT test if he want. (looks low risk as not used at all)

@stephenchengCloud
Copy link
Contributor

This PR looks good by itself,

@stephenchengCloud Please prepare a feature branch with this update so @ashwin9390 can do rpm/XenRT test if he want. (looks low risk as not used at all)

You mean a feature branch for xapi.spec repo? Sure, will do it.

Copy link
Collaborator

@bernhardkaindl bernhardkaindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the comments by Lin and Stephen, I understand the following from what Lin wrote:

The team is now aware that when merging it, xapi.spec will be updated as well. Also, complete XenRT testing will be done as well when all changes need to be tested for the merge of the feature branch.

On this ground, I think I can also add my approval to the PR.

@liulinC liulinC merged commit f1d09ce into xapi-project:feature/py3 Jul 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants