QueryParser: do not try to parse unbroken words as group terms #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where QueryParser fails with an error when parsing the sequence of: term, whitespace, unbroken words, term. The underlying issue is that unbroken words can not be part of a group according to the lemon grammar. As the combination of unbroken words and terms is highly unlikely to ever form a multi-term synonym, this patch changes the query parser to leave group term mode after having parsed unbroken words.
rsto
added a commit
to cyrusimap/xapian
that referenced
this pull request
Jan 25, 2024
This is submitted upstream at xapian#331 --- Original commit message: Fixes a bug where QueryParser fails with an error when parsing the sequence of: term, whitespace, unbroken words, term. The underlying issue is that unbroken words can not be part of a group according to the lemon grammar. As the combination of unbroken words and terms is highly unlikely to ever form a multi-term synonym, this patch changes the query parser to leave group term mode after having parsed unbroken words.
rsto
added a commit
to cyrusimap/cyruslibs
that referenced
this pull request
Jan 25, 2024
Submitted upstream at xapian/xapian#331
|
Thanks. Seems reasonable, but I'd like to have a look at the wider context before merging. |
|
Sorry about taking so long to getting to looking into this. I wondered if we should also be doing the I think you're right that we don't need to worry about trying multi-word synonyms in this situation - they'd need to include words from different scripts. If someone really wants that to work we can revisit. I think it'd be good to exercise the |
ojwb
pushed a commit
that referenced
this pull request
Mar 7, 2024
Fixes a bug where QueryParser fails with an error when parsing the sequence of: term, whitespace, unbroken words, term. The underlying issue is that unbroken words can not be part of a group according to the lemon grammar. As the combination of unbroken words and terms is highly unlikely to ever form a multi-term synonym, this patch changes the query parser to leave group term mode after having parsed unbroken words. Fixes #331 (cherry picked from commit 624207c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where QueryParser fails with an error when parsing the sequence of: term, whitespace, unbroken words, term. The underlying issue is that unbroken words can not be part of a group according to the lemon grammar.
As the combination of unbroken words and terms is highly unlikely to ever form a multi-term synonym, this patch changes the query parser to leave group term mode after having parsed unbroken words.