-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added earth-relative wind field calculation to base diagnostics #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good! I initially thought that grid-relative/earth-relative conversion would be the kind of general-purpose thing to leave to MetPy to handle, but likewise to geopotential to geopotential height, this looks to have enough WRF-specific nuance to justify handling here.
A couple small suggestions:
- Update the documentation of
postprocess
's Parameters to account for these new fields and that unlike the other diagnostic variables, the grid-relative winds are not dropped whendrop_diagnostic_variable_components
is true. - Use expected input type for
_destag_variable
(see suggestion below)
Co-authored-by: Anderson Banihirwe <axbanihirwe@gmail.com>
Co-authored-by: jthielen <jon@thielen.science>
dff337e
to
53f0fc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I'll hold off merging in case you wanted further reviews from anyone else or to iterate on this in PR form still. That being said, if you want to get this in for v0.0.2 and build tutorial/blog post components around it, feel free to merge.
I think I'll merge pursuant to your and @andersy005's review. Thanks, guys! |
Change Summary
This might not be the best way to implement this, but I think we should also include earth-relative wind field calculation if we already have the other diagnostics. What are your opinions?
Checklist
PS:
For me, locally, this change causes the test
tests/test_accessors.py:15 test_postprocess[lambert_conformal-lambert_conformal_conic]
to fail, though I think this is an unrelated bug. However, I don't know enough aboutcf_xarray
to debug this.The error is: