Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue template #34

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Conversation

lpilz
Copy link
Collaborator

@lpilz lpilz commented Jan 25, 2022

Change Summary

Added a title prefix to other.yml in order to fix bug with template

Related issue number

@lpilz lpilz requested a review from andersy005 January 25, 2022 00:14
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this, @lpilz! We still need to fix the body section:

Screen Shot 2022-01-25 at 12 19 24 PM

@@ -1,6 +1,6 @@
name: Issue
description: General Issue
title: ''
title: '[ISSUE]: '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use a nonredundant prefix e.g. MISC for miscellaneous? What do you think

Suggested change
title: '[ISSUE]: '
title: '[MISC]: '

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure we can :) I went maybe a bit overboard with keeping it in line with [Bug]: and [FEATURE]: ;)

@lpilz
Copy link
Collaborator Author

lpilz commented Jan 27, 2022

Is there any way one can test this locally? I feel like I'm flying a bit blind here...

Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @lpilz!

@andersy005 andersy005 merged commit 161905d into xarray-contrib:main Jan 28, 2022
lpilz added a commit that referenced this pull request Sep 16, 2022
jthielen pushed a commit that referenced this pull request Sep 19, 2022
jthielen pushed a commit that referenced this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Broken Issue Template
2 participants