Skip to content
This repository has been archived by the owner on Dec 12, 2020. It is now read-only.

Java 10 #30

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Java 10 #30

wants to merge 1 commit into from

Conversation

xeruf
Copy link
Owner

@xeruf xeruf commented Sep 16, 2018

Fixes #20
Fixes #22

Still hoping to reduce the size. Self-contained application is currently about 160 MB.

@Swiftb0y
Copy link

Swiftb0y commented Sep 3, 2019

Hey, I'd actually like to use some newer features of the downloader but I am forced to use the java10 branch...
Would you consider to merge this any time soon?

@defvs
Copy link
Collaborator

defvs commented Sep 4, 2019

Why are you stuck with Java 10 ?

@Swiftb0y
Copy link

Swiftb0y commented Sep 4, 2019

Basically I can't get Java 8 to build the project. But it works with Java 10.

@defvs
Copy link
Collaborator

defvs commented Sep 6, 2019

Here are some common issues we've had with other users :

  • If you're on linux and you're using OpenJDK, please install the openjfx package.
  • Please use Oracle JDK for building if OpenJDK still doesn't work
  • Clear the build directory
  • Clone it again

@xeruf xeruf marked this pull request as draft June 15, 2020 13:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to JDK 10 Songs newer than "Hush - Watervaal" cannot be played in the Player
3 participants