Merge #1730

1730: fix: correctly initialize import component context r=KnisterPeter a=KnisterPeter The import component context should be initialized with undefined, as this is the expected behavior of the Import Component. Co-authored-by: Markus Wolf <mail@markus-wolf.de>
xing · Apr 15, 2021 · 82251b2 · 82251b2
2 parents 670e955 + e9dd60d
commit 82251b2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/react/import-component/context.js b/packages/react/import-component/context.js
@@ -1,6 +1,6 @@
 import { createContext } from 'react';
 
-const context = createContext({});
+const context = createContext(undefined);
 
 context.displayName = 'Hops.ImportComponent';
 

diff --git a/packages/react/import-component/index.js b/packages/react/import-component/index.js
@@ -71,7 +71,7 @@ export const importComponent = (
     }
 
     return createElement(Importer, {
-      hasModules: Boolean(modules),
+      hasModules: Boolean(modules && modules.length > 0),
       loader,
       render,
       ownProps,