Fix for handling of alphabetic repetition separator #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Valid X12 ISA headers can sometimes include an alpha-numeric character at element 11. In that case, the value should be ignored in favor of the default repetition separator "^"
We've encountered real world messages that have a
V
at ISA 11 fail to parse with the following error message on later events. I'm Assuming that aV
was encountered elsewhere in the segments and the parser assumed that it was a control character.Besides the spec, there's supporting evidence for this here: https://www.ibm.com/support/pages/isa-11-repetition-separator-letter-u-and-u-character-data-it-does-not-fail-x12-deenvelope
Fix
This change checks will
elementRepeater
to the default if the header value is alphabetic