Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct implementation segment selection at loop start for single match #80

Merged
merged 4 commits into from
Aug 7, 2020
Merged

Correct implementation segment selection at loop start for single match #80

merged 4 commits into from
Aug 7, 2020

Conversation

MikeEdgar
Copy link
Member

Fixes #79

@MikeEdgar MikeEdgar added this to the v1.9.4 milestone Aug 6, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2020

Pull Request Test Coverage Report for Build 198420294

  • 16 of 16 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 96.963%
Files with Coverage Reduction New Missed Lines %
src/main/java/io/xlate/edi/internal/stream/validation/Validator.java 1 98.26%
Totals Coverage Status
Change from base Build 191520055: -0.02%
Covered Lines: 4215
Relevant Lines: 4347
💛 - Coveralls

@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@MikeEdgar MikeEdgar merged commit 397597d into master Aug 7, 2020
@MikeEdgar MikeEdgar deleted the 79_impl_loop_without_elements branch August 7, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.4
Development

Successfully merging this pull request may close these issues.

Validation of edifact fails when an empty segment starts a loop in an implementation schema
1 participant
@MikeEdgar