ci: upload to pypi on github release #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use pypi github action to upload the artifact of a build. A tag must be present on the commit being built. Fixes xlwings#75
|
Thanks, this looks great! Hope to release this soon! |
fzumstein
reviewed
Jun 1, 2024
|
I left one question in the code comments (just to make sure you see it). |
|
I've added the GH Actions secret -- do you want to give it a go and make a new release? |
|
Nice, I'll give it a go! |
|
Cool, all set. https://pypi.org/project/jsondiff/ Took a second try because the pypi pkg-info was broken. That's why we have a 2.1.0 and an immediate 2.1.1. |
|
Installed and tested in a fresh env, looks good to me. |
|
👏 awesome, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pypi github action to upload the artifact of a build. A tag must be present on the commit being built which a normal
Github Release should provide. We can also add an on tag push trigger if that helps.
I tested this on my fork by adding an upload artifact step, downloading the wheel, and installing in a venv. The version
reports correctly and the cli tool runs as expected. If possible, it might be nice to publish to a pypi dev first to make sure
other people can test it.
Fixes #75