Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Sheet.add_data_validations typespec #154

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

rodrigues
Copy link
Contributor

@rodrigues rodrigues commented Jul 29, 2024

Hi 👋

This PR fixes Sheet.add_data_validations typespec, including currently supported use case when instead of a values list the user passes one string with a reference within excel (e.g. "RefSheet!$A$2:$A$32").

The function call will not succeed.

Elixlsx.Sheet.add_data_validations(_sheet :: any(), <<_::8, _::size(1)>>, <<_::8, _::size(1)>>, <<_::8, _::size(1)>>)

breaks the contract
(t(), String.t(), String.t(), [String.t()]) :: t()

Thanks!

@xou xou merged commit 9b34729 into xou:master Aug 7, 2024
2 checks passed
@xou
Copy link
Owner

xou commented Aug 7, 2024

thank you!

@rodrigues rodrigues deleted the fix_add_data_validations_spec branch August 8, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants