Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

row/col outline level (grouping) support #74

Merged
merged 5 commits into from
Feb 28, 2019

Conversation

mtannaan
Copy link
Contributor

Hi. Thank you for providing this wonderful library, which is so simple to use! (I also use Python's openpyxl, but tired of its messy API...)

I personally had a work where I had to group rows/columns, just like the following article:
https://oxen.tech/blog/grouping-excel/

I forked xlixlsx and made some changes to do this.
I'd appreciate it if you review and merge my changes so that everyone can use this feature via Hex!

Your comments and edits are very appreciated.

@xou
Copy link
Owner

xou commented Jan 23, 2019

Hi!

Thanks for adding this feature!
"Outline Levels" is unfortunately not trivial to understand without knowledge of how this is implemented (or the xlsx spec). I am wondering whether a better interface could take parameters such as (group_rows: [[1, 10], [3, 5, hide:true]]); and the outline levels (and "hidden" parameter) are then calculated automatically?

WDYT?

@mtannaan
Copy link
Contributor Author

Thanks for the response!
Sounds great, we are "grouping rows" when using Excel, rather than "setting outline levels."
I'll make some edits to support this.

@mtannaan
Copy link
Contributor Author

Changed row/col_outline_levels to group_rows/columns and added support for :collapsed option.
I'd be glad if you check this is aligned to your suggestion.

@xou xou merged commit ed782f5 into xou:master Feb 28, 2019
@xou
Copy link
Owner

xou commented Feb 28, 2019

Awesome, thanks for this!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants