Try to unlock the keyring collection when it is locked #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xou816
approved these changes
Feb 12, 2023
|
works perfectly, gnome shell shows a prompt if the keyring is locked. its a bit surprising perhaps, but better than what we have now :) i assume it should be possible to customize the prompt, i'll look into it someday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On KDE plasma, the secret service is initially locked even though the kwallet is unlocked. Currently if spot is the first application to require the wallet it will fail to access it. My current workaround is to open another app that unlock the wallet and then opening spot.
With this PR, spot will try to unlock the keyring collection if it is locked, resulting on a prompt asking the user for the keyring password, if the keyring unlocking fail, the behavior should be the same as before.
It should help #274 at least on the KDE side. I tested this PR on KDE, can you check if no regression are present on GNOME ?