Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconventional cron not throwing error but changes cron value to closest accepted value #31

Closed
jianminggit opened this issue Aug 22, 2022 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jianminggit
Copy link

jianminggit commented Aug 22, 2022

Describe the bug
Unconventional cron pasted in a text field does not throw an error but forcibly changing the select dropdown to its closest accepted value.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://xrutayisire.github.io/react-js-cron/?path=/docs/reactjs-cron--track-error'
  2. Type * * * * Sun#3 in the text input
  3. Select input resets the cron value to the closest accepted value
  4. No error shown

Expected behavior
An error should be thrown

@xrutayisire xrutayisire self-assigned this Sep 2, 2022
@xrutayisire xrutayisire added bug Something isn't working good first issue Good for newcomers labels Sep 2, 2022
@xrutayisire
Copy link
Owner

Thanks for the issue, good catch :)

I will try to find time during the weekend to fix this bug.

@xrutayisire
Copy link
Owner

v2.1.2 is released with the fix! 🎉

It will throw an error now if any value is not correct!
You can reopen this issue if you still found some Cron that should throw an error but don't 🙂

Have a good day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants