Add various defaults #146
Draft
Add various defaults #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apexskier
force-pushed
the
apexskier-defaults
branch
from
663d012
to
9dde7b7
Compare
|
What do you think about a "Global" category? |
|
I think global for I'd personally get rid of the "custom" categories and make it all based on the I think everything's currently organized by domain except |
apexskier
added a commit
to apexskier/macos-defaults
that referenced
this pull request
Apr 4, 2021
This reorganizes defaults file by domain and hoists the domain up into the category section. I was fixing some of the descriptions to make them proper markdown, and I discovered they actually aren't processed as markdown like I thought, which means the meta tags and the layout on category pages broke when I started using real markdown. I've updated the templates to fix this. I've also tightened up the json schema a bit, which can also be extracted from this PR. I'm going to need to apply the markdown fixes for yannbertrand#146, but the reorganization is a proposal for discussion.
apexskier
added a commit
to apexskier/macos-defaults
that referenced
this pull request
Apr 4, 2021
This reorganizes defaults file by domain and hoists the domain up into the category section. I was fixing some of the descriptions to make them proper markdown, and I discovered they actually aren't processed as markdown like I thought, which means the meta tags and the layout on category pages broke when I started using real markdown. I've updated the templates to fix this. I've also tightened up the json schema a bit, which can also be extracted from this PR. I'm going to need to apply the markdown fixes for yannbertrand#146, but the reorganization is a proposal for discussion.
|
Here's an example of that organization - apexskier/macos-defaults@markdown-support...apexskier:domain-organization |
|
I prefer to keep the categories as is, which is easier to understand from a non-dev/end user perspective |
apexskier
added a commit
to apexskier/macos-defaults
that referenced
this pull request
Apr 5, 2021
Currently, page url generation (slugification) is just toLowerCase. In yannbertrand#146 I add some defaults that contain keys with spaces, which currently breaks. This pulls in `slugify` to add support, and shell escapes keys in examples.
yannbertrand
pushed a commit
that referenced
this pull request
Apr 6, 2021
Currently, page url generation (slugification) is just toLowerCase. In #146 I add some defaults that contain keys with spaces, which currently breaks. This pulls in `slugify` to add support, and shell escapes keys in examples.
yannbertrand
pushed a commit
that referenced
this pull request
Apr 6, 2021
Currently, page url generation (slugification) is just toLowerCase. In #146 I add some defaults that contain keys with spaces, which currently breaks. This pulls in `slugify` to add support, and shell escapes keys in examples.
yannbertrand
pushed a commit
that referenced
this pull request
Apr 6, 2021
Currently, page url generation (slugification) is just toLowerCase. In #146 I add some defaults that contain keys with spaces, which currently breaks. This pulls in `slugify` to add support, and shell escapes keys in examples.
|
Is the PR still a Draft? Let me know if I can review it 🙂 |
yannbertrand
force-pushed
the
master
branch
2 times, most recently
from
0099add
to
70e4323
Compare
yannbertrand
force-pushed
the
main
branch
2 times, most recently
from
a7bc1a8
to
9feedb1
Compare
Gudsfile
pushed a commit
to Gudsfile/macos-defaults
that referenced
this pull request
Oct 16, 2022
Currently, page url generation (slugification) is just toLowerCase. In yannbertrand#146 I add some defaults that contain keys with spaces, which currently breaks. This pulls in `slugify` to add support, and shell escapes keys in examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just found this site/repo and it's exactly what I was looking for. I normally manually hunt for defaults or use https://www.defaults-write.com (which is not really organized in a useful manner), and this looks like exactly the setup I've wanted.
I have my own system for managing defaults across multiple computers and have a pretty extensive collection I'd like to start contributing to this repository. This PR kicks things off with a number of global apple configurations, many of which come from the system preferences.
Edit: I've now added quite a bit more, and will probably keep doing so until #150 and #151 are in.