Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

componentWillReceiveProps is not recommended for use. #3

Closed
bfaulk96 opened this issue Jan 28, 2020 · 2 comments
Closed

componentWillReceiveProps is not recommended for use. #3

bfaulk96 opened this issue Jan 28, 2020 · 2 comments
Assignees
@yasaricli

Comments

@bfaulk96
Copy link
Contributor

When using Dots in a react-native app, the following warning now display:
YellowBox.js:71 Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

This could be changed to use componentDidUpdate() instead and still have the desired effects.
bfaulk96 pushed a commit to bfaulk96/react-native-dots-pagination that referenced this issue Jan 28, 2020
Update to follow React-Native best practices
f907d3a 
As mentioned in yasaricli#3, `componentWillReceiveProps` is not recommended for use, and `componentDidUpdate()` is suggested as a replacement for side-effects (https://fb.me/react-async-component-lifecycle-hooks)
@bfaulk96 bfaulk96 mentioned this issue Jan 28, 2020
Merged
@yasaricli yasaricli self-assigned this Jan 29, 2020
@yasaricli
Copy link
Owner

yasaricli commented Jan 29, 2020 •
edited
Loading

thanks, @bfaulk96 i will review. #4

@yasaricli
Copy link
Owner

yasaricli commented Jan 30, 2020 •
edited
Loading

@bfaulk96 0.1.9 is published, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yasaricli yasaricli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yasaricli @bfaulk96