Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] WIP: Signature help #1255

Closed
wants to merge 6 commits into from
Closed

[RFC] WIP: Signature help #1255

wants to merge 6 commits into from

Commits on Sep 18, 2019

  1. Ignore build output directories created by roslyn

    @puremourning
    puremourning committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    ba1d681 View commit details
    Browse the repository at this point in the history

  2. SignatureHelp: Document API

    @puremourning
    puremourning committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    f0e3001 View commit details
    Browse the repository at this point in the history

  3. SignatureHelp: Support signature help for c-family using clangd 

    This implements the LSP signature help support and tests it for clangd.

A new options was added: disable_signature_help. if for some reason you
don't like signature help, this can be set to disable it.

NOTE: No special changes were required to clangd_completer as this is
implemnented completesly in the language_server_completer layer.
Therefore, this change acutally makes signature help work for any LSP
based completer, while tests are only provided (for now) for c-family
using clangd..

This isn't perfect yet: there's no capability mechanism to indicate
that signature help isn't supported for a filetype so the client will
just constantly send requests that return emnpty. For now, we don't
solve that, instead deferring that decision to either send an error
(like we do with the message poll), or add a new capability response,
e.g. to the completer available reqeust (such as adding a version 2 of
that request that returns an objext).
    @puremourning
    puremourning committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    6225e6f View commit details
    Browse the repository at this point in the history

  4. Python: implement signature help

    @puremourning
    puremourning committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    773ca21 View commit details
    Browse the repository at this point in the history

  5. Java: Implement and test signatiure help

    @puremourning
    puremourning committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    b341e1f View commit details
    Browse the repository at this point in the history

  6. Go: Implement and test signature help

    @puremourning
    puremourning committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    06e03ff View commit details
    Browse the repository at this point in the history