Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document unittest_args in run_tests.py --help #1761

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dkaszews
Copy link
Contributor

@dkaszews dkaszews commented Sep 16, 2024

Adds a line of help after usage to document run_tests.py passing unknown arguments to unittest.

 > ./run_tests.py --help
 usage: run_tests.py [-h] [--no-completers [{cfamily,cs,javascript,typescript,python,java,clangd,rust,go} ...] | --completers 
[{cfamily,cs,javascript,typescript,python,java,clangd,rust,go} ...]] [--skip-build]
                     [--msvc {15,16,17}] [--coverage] [--no-flake8] [--dump-path] [--no-retry] [--quiet] [--valgrind]
 
+Unknown arguments are passed to unittest module, e.g. to select test cases. See `python -m unittest --help` for more details.
 
 options:

This change is Reviewable

Copy link
Collaborator

@bstaletic bstaletic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request.

I think we should just drop --no-clang-completer, --no-completers and --completers. Those arguments have been a no-op for who knows how long.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @dkaszews)

Copy link
Contributor Author

@dkaszews dkaszews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? They are used by the BuildYcmdLibs, though it is a bit misleading as it would make more sense if they selected tests, not build components:

> .\run_tests.py
Running tests on Python 3.12.4
Running flake8
DKASZEWS: subprocess.check_call( ['C:\\Program Files\\Python312\\python.exe', 'C:\\Users\\dkaszews\\AppData\\Local\\nvim-data\\plugged\\YouCompleteMe\\third_party\\ycmd\\build.py', '--core-tests', '--clang-completer', '--cs-completer', '--js-completer', '--ts-completer', '--java-completer', '--clangd-completer', '--rust-completer', '--go-completer', '--msvc', '16'] )

> .\run_tests.py --completers cs
Running tests on Python 3.12.4
Running flake8
DKASZEWS: subprocess.check_call( ['C:\\Program Files\\Python312\\python.exe', 'C:\\Users\\dkaszews\\AppData\\Local\\nvim-data\\plugged\\YouCompleteMe\\third_party\\ycmd\\build.py', '--core-tests', '--cs-completer', '--msvc', '16
'] )

Reviewable status: 0 of 2 LGTMs obtained (waiting on @dkaszews)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants