Skip to content

Commit

Permalink
Merge pull request #1312 from ydb-platform/fix-resullt-set-parts-reading
Browse files Browse the repository at this point in the history
Do not check ResultSetIndex when ResuilSet is nil.
  • Loading branch information
neyguvj committed Jun 27, 2024
2 parents 42ca696 + c811a3e commit fdea098
Show file tree
Hide file tree
Showing 3 changed files with 79 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
* Fixed bug with reading empty result set parts.
* Fixed nil pointer dereference when closing result set

## v3.74.4
Expand Down
2 changes: 1 addition & 1 deletion internal/query/result_set.go
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ func (rs *resultSet) nextRow(ctx context.Context) (*row, error) {
return nil, xerrors.WithStackTrace(io.EOF)
}
}
if rs.index != rs.currentPart.GetResultSetIndex() {
if rs.currentPart.GetResultSet() != nil && rs.index != rs.currentPart.GetResultSetIndex() {
close(rs.done)

return nil, xerrors.WithStackTrace(fmt.Errorf(
Expand Down
77 changes: 77 additions & 0 deletions tests/integration/query_multi_result_sets_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
//go:build integration
// +build integration

package integration

import (
"context"
"errors"
"fmt"
"io"
"os"
"testing"

"github.com/ydb-platform/ydb-go-sdk/v3/internal/version"
"github.com/ydb-platform/ydb-go-sdk/v3/query"
)

func TestQueryMultiResultSets(t *testing.T) {
if version.Lt(os.Getenv("YDB_VERSION"), "24.1") {
t.Skip("query service not allowed in YDB version '" + os.Getenv("YDB_VERSION") + "'")
}

scope := newScope(t)
var i, j, k int
db := scope.Driver()
err := db.Query().Do(scope.Ctx, func(ctx context.Context, s query.Session) (err error) {
_, res, err := s.Execute(ctx, `SELECT 42; SELECT 43, 44;`)
if err != nil {
return fmt.Errorf("can't get result: %w", err)
}
set, err := res.NextResultSet(ctx)
if err != nil {
return fmt.Errorf("set 0: get next result set: %w", err)
}

for row, err := set.NextRow(ctx); !errors.Is(err, io.EOF); row, err = set.NextRow(ctx) {
if err != nil {
return fmt.Errorf("set 0: get next row: %w", err)
}
if err := row.Scan(&i); err != nil {
return fmt.Errorf("set 0: scan row: %w", err)
}
fmt.Println(i)
}

set, err = res.NextResultSet(ctx)
if err != nil {
return err
}

for row, err := set.NextRow(ctx); !errors.Is(err, io.EOF); row, err = set.NextRow(ctx) {
if err != nil {
return fmt.Errorf("set 1: get next row: %w", err)
}

if err := row.Scan(&j, &k); err != nil {
return fmt.Errorf("set 1: scan row: %w", err)
}
fmt.Println(j, k)
}
_, err = res.NextResultSet(ctx)
if !errors.Is(err, io.EOF) {
return fmt.Errorf("get next result set: %w", err)
}

if res.Err() != nil {
return fmt.Errorf("res.Err() = %w", res.Err())
}
return nil
}, query.WithIdempotent())

scope.Require.NoError(err)

scope.Require.Equal(42, i)
scope.Require.Equal(43, j)
scope.Require.Equal(44, k)
}

0 comments on commit fdea098

Please sign in to comment.