Fix parallel build: Delay toplevel database reads #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling camomile using several cores it might fail with the following errors (with backtraces):
This PR fixes the issue. One thing I don't understand is how the call to
read_data "acset"
inColParser
didn't make everything fail every time since it is included in thetoolslib
library and this library is used to createacset.mar
itself..Anyway, I think avoiding side-effects on toplevel (even inside functors) is a good practice in any case.
Related to ocaml/opam-repository#13980