Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise an error when we encounter malformed yamls #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jianingy
Copy link
Contributor

Hi,

This patch uses 'die' to report a malformed yaml error.

Well, I dont think use $self->error in _init is a good idea since Class.pm says that $self->error is used for handling method's error, for example,

warn($obj->error) if (!$obj->do_sth);

When we are in _init context, return $self->error('error message') actually returns an undef that makes the object invisible to a caller and make it impossible to get $obj->{_error}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant