Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LNumber.String() use strconv instead of fmt.Sprint #468

Open
2 tasks done
MrParano1d opened this issue Dec 21, 2023 · 1 comment · May be fixed by #469
Open
2 tasks done

LNumber.String() use strconv instead of fmt.Sprint #468

MrParano1d opened this issue Dec 21, 2023 · 1 comment · May be fixed by #469

Comments

@MrParano1d
Copy link

You must post issues only here. Questions, ideas must be posted in discussions.

  • GopherLua is a Lua5.1 implementation. You should be familiar with Lua programming language. Have you read Lua 5.1 reference manual carefully?
  • GopherLua is a Lua5.1 implementation. In Lua, to keep it simple, it is more important to remove functionalities rather than to add functionalities unlike other languages . If you are going to introduce some new cool functionalities into the GopherLua code base and the functionalities can be implemented by existing APIs, It should be implemented as a library.

Please answer the following before submitting your issue:

  1. What version of GopherLua are you using? : v1.1.1
  2. What version of Go are you using? : go1.21.0 linux/amd64
  3. What operating system and processor architecture are you using? : Win11 with WSL2
  4. What did you do? : use tostring on a number
  5. What did you expect to see? : use go formatting function for the datatype
  6. What did you see instead? : fmt.Sprint
MrParano1d added a commit to MrParano1d/gopher-lua that referenced this issue Dec 21, 2023
@MrParano1d
Copy link
Author

Created PR. This will increase the performance in high traffic applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant