Typhoeus.stub should not be converted to new rspec syntax

[myronmarston]

First off, great work on this project! If this continues to stay up-to-date with RSpec as we approach the 3.0 release (still a ways off), I plan to promote this and point users to it as an aid to upgrading.

Anyhow, I tried it for the first time tonight to upgrade VCR's specs, and ran into one issue.

Typhoeus provides an HTTP stubbing API in the form of Typhoeus.stub(url, options):

https://github.com/typhoeus/typhoeus/blob/6a59c62d7e8bda81ec726035b79e035aefd8b05c/lib/typhoeus.rb#L66-L85

Transpec attempted to upgrade this to RSpec's allow(...).to receive syntax but it was invalid because ::Typhoeus.stub isn't using rspec's stub at all even though it looks like it. While this isn't really a bug in transpec (how could it know?) I think it could help if transpec maintained a whitelist of known exceptions for things it should not attempt to upgrade, and ::Typhoeus.stub could be on the list. There may be others other users will report in the future.

[yujinakayama]

Thanks! Yeah, I'll keep Transpec up-to-date with RSpec.

I think it could help if transpec maintained a whitelist of known exceptions for things it should not attempt to upgrade, and ::Typhoeus.stub could be on the list.

The whitelist solution sounds good to me. Typhoeus seems to be famous and the name is unique enough.

[myronmarston]

Thanks for the quick fix :).

[myronmarston]

BTW, I noticed that Excon has a .stub method as well -- it should probably go in the whitelist, too.

[yujinakayama]

Thanks. I'll handle it too.

By the way, I'm wondering if there's a way to grep codes of all gems.

[myronmarston]

You could try searching rubydoc.info:

https://www.google.com/search?q=stub+site%3Arubydoc.info&oq=stub+site%3Arubydoc.info&aqs=chrome..69i57j0l5.2912j0&sourceid=chrome&espvd=210&es_sm=91&ie=UTF-8

[yujinakayama]

Thanks! I'll try later.

[yujinakayama]

Now Transpec checks whether #stub (and all other methods) is defined by RSpec or not with runtime information, rather than the static whiltelist. :)

[myronmarston]

👍 Sounds great!