Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-105 Legacy context implementation cleanup #106

Merged
merged 3 commits into from
May 10, 2024

Conversation

rameshmalla
Copy link
Contributor

Close #105

@lukasniemeier-zalando
Copy link
Collaborator

Looking good. There is no documentation to be updated right now in scope of this PR, or?

@lukasniemeier-zalando
Copy link
Collaborator

Also I wonder what we do with the interface ConfigurationMethodInvocationHandler which continues to have a single implementation, provide it for anyone to provide their own custom implementation?

@rameshmalla
Copy link
Contributor Author

rameshmalla commented May 10, 2024

Looking good. There is no documentation to be updated right now in scope of this PR, or?

We didnt had proper documentation on the usage of context, but the wiki is already updated with the updated usage of context https://github.com/zalando-stups/baigan-config/wiki/Baigan-Conditions#baigan-context. We are catching up with wiki 😄

@rameshmalla
Copy link
Contributor Author

Also I wonder what we do with the interface ConfigurationMethodInvocationHandler which continues to have a single implementation, provide it for anyone to provide their own custom implementation?

I didn't have the chance to look at the potential usage, maybe we don't need this anymore. But we can address this as part of our upcoming improvements.

@lukasniemeier-zalando
Copy link
Collaborator

Looking good. There is no documentation to be updated right now in scope of this PR, or?

We didnt had proper documentation on the usage of context, but the wiki is already updated with the updated usage of context https://github.com/zalando-stups/baigan-config/wiki/Baigan-Conditions#baigan-context. We are catching up with wiki 😄

Ok thanks

@lukasniemeier-zalando
Copy link
Collaborator

👍

@lukasniemeier-zalando lukasniemeier-zalando merged commit e8f66bf into zalando-stups:main May 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants