Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary debug log for ###ZARF_DATA_INJECTON_MARKER### #2267

Closed
RothAndrew opened this issue Jan 29, 2024 · 0 comments · Fixed by #2581
Closed

Unnecessary debug log for ###ZARF_DATA_INJECTON_MARKER### #2267

RothAndrew opened this issue Jan 29, 2024 · 0 comments · Fixed by #2581
Assignees
@schristoff-du
Labels
tech-debt 💳 Debt that the team has charged and needs to repay

Comments

@RothAndrew
Copy link
Contributor

When doing a data injection, this line appears in the debug log every time. It caused a fair bit of confusion for me as I did not notice that it was a misspelling (INJECTON -> INJECTION).

image (1)

This line is likely just not needed. It is logging something that will be the same every time. Removing it would also remove the potential source for confusion.
@Racer159 Racer159 added the tech-debt 💳 Debt that the team has charged and needs to repay label Feb 6, 2024
@schristoff-du schristoff-du self-assigned this May 9, 2024
@schristoff-du schristoff-du mentioned this issue Jun 4, 2024
Merged
AustinAbro321 pushed a commit that referenced this issue Jun 5, 2024
@schristoff-du @schristoff
chore: deprecate DeprecatedKeys (#2581)
d832c60 
Fixes #2267

Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
Co-authored-by: schristoff <28318173+schristoff@users.noreply.github.com>
AustinAbro321 pushed a commit that referenced this issue Jul 23, 2024
@schristoff-du @schristoff @AustinAbro321
chore: deprecate DeprecatedKeys (#2581)
a3de04a 
Fixes #2267

Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
Co-authored-by: schristoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schristoff-du schristoff-du

Labels
tech-debt 💳 Debt that the team has charged and needs to repay
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: deprecate DeprecatedKeys schristoff/zarf
3 participants
@Racer159 @RothAndrew @schristoff-du