Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove component webhooks #2724

Closed
wants to merge 1 commit into from
Closed

Conversation

lucasrod16
Copy link
Contributor

@lucasrod16 lucasrod16 commented Jul 12, 2024

Description

remove component webhooks

Related Issue

Fixes #2610
Relates to #2562

@lucasrod16 lucasrod16 requested review from dgershman and a team as code owners July 12, 2024 20:56
Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit bbf3445
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6697e4f099e0a900088df12b
😎 Deploy Preview https://deploy-preview-2724--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 19.46%. Comparing base (ff50f77) to head (bbf3445).

Files Patch % Lines
src/pkg/packager/deploy.go 0.00% 26 Missing ⚠️
src/pkg/cluster/zarf.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2724      +/-   ##
==========================================
+ Coverage   19.44%   19.46%   +0.02%     
==========================================
  Files         171      171              
  Lines       12158    12091      -67     
==========================================
- Hits         2364     2354      -10     
+ Misses       9494     9437      -57     
  Partials      300      300              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucasrod16 lucasrod16 reopened this Jul 17, 2024
@phillebaba
Copy link
Member

Code wise this looks good. Removing this cleans up code if it is not used.

@lucasrod16 lucasrod16 marked this pull request as draft July 19, 2024 17:15
@schristoff schristoff closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove component webhooks
3 participants