refactor: move validate to lint #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
schristoff
previously approved these changes
Aug 7, 2024
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321
commented
Aug 12, 2024
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
schristoff
approved these changes
Aug 12, 2024
mjnagel
pushed a commit
to defenseunicorns/uds-core
that referenced
this pull request
Aug 14, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | ghcr.io/zarf-dev/packages/init | patch | `v0.38.1` -> `v0.38.2` | | [zarf-dev/zarf](https://github.com/zarf-dev/zarf) | patch | `v0.38.1` -> `v0.38.2` | --- ### Release Notes <details> <summary>zarf-dev/zarf (zarf-dev/zarf)</summary> ### [`v0.38.2`](https://github.com/zarf-dev/zarf/releases/tag/v0.38.2) [Compare Source](https://github.com/zarf-dev/zarf/compare/v0.38.1...v0.38.2) ##### What's Changed - chore(deps): bump github.com/google/go-containerregistry from 0.20.1 to 0.20.2 by [@​dependabot](https://github.com/dependabot) in [zarf-dev/zarf#2863 - chore(deps): bump k8s.io/kubectl from 0.30.0 to 0.30.3 by [@​dependabot](https://github.com/dependabot) in [zarf-dev/zarf#2862 - ci: add renamed github workflow jobs to the shim workflow by [@​AustinAbro321](https://github.com/AustinAbro321) in [zarf-dev/zarf#2858 - test: docker exec to in memory registry by [@​AustinAbro321](https://github.com/AustinAbro321) in [zarf-dev/zarf#2869 - fix: replace helpers.Retry with go-retry and adjust delay by [@​phillebaba](https://github.com/phillebaba) in [zarf-dev/zarf#2856 - feat: introduce beta schema by [@​AustinAbro321](https://github.com/AustinAbro321) in [zarf-dev/zarf#2859 - refactor: move validate to lint by [@​AustinAbro321](https://github.com/AustinAbro321) in [zarf-dev/zarf#2839 **Full Changelog**: zarf-dev/zarf@v0.38.0...v0.38.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change refactors the runtime validate code to live next to the schema validate code. This will keep the v1alpha1 package to strictly hold the type, and will make it easier for the runtime validation code to happen on lint.
Relates to #2852
Checklist before merging