Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: proxy and add tests #2843

Merged
merged 2 commits into from
Aug 6, 2024
Merged

refactor: proxy and add tests #2843

merged 2 commits into from
Aug 6, 2024

Conversation

phillebaba
Copy link
Member

Description

This change cleans up logging and adds tests to the proxy.

Related Issue

Relates to #2576

Checklist before merging

Signed-off-by: Philip Laine <philip.laine@gmail.com>
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 4.83871% with 59 lines in your changes missing coverage. Please review.

Files Patch % Lines
src/internal/agent/start.go 0.00% 30 Missing ⚠️
src/internal/agent/http/proxy.go 12.50% 21 Missing ⚠️
src/cmd/internal.go 0.00% 8 Missing ⚠️
Files Coverage Δ
src/cmd/internal.go 0.00% <0.00%> (ø)
src/internal/agent/http/proxy.go 37.36% <12.50%> (+37.36%) ⬆️
src/internal/agent/start.go 0.00% <0.00%> (ø)

@phillebaba phillebaba marked this pull request as ready for review August 6, 2024 14:16
@phillebaba phillebaba requested review from a team as code owners August 6, 2024 14:16
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Aug 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 6, 2024
Copy link
Contributor

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work :)

src/cmd/internal.go Show resolved Hide resolved
src/internal/agent/start.go Show resolved Hide resolved
@schristoff schristoff added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit e9c756b Aug 6, 2024
26 checks passed
@schristoff schristoff deleted the refactor/proxy branch August 6, 2024 22:19
mjnagel pushed a commit to defenseunicorns/uds-core that referenced this pull request Aug 9, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| ghcr.io/zarf-dev/packages/init | minor | `v0.37.0` -> `v0.38.1` |
| [zarf-dev/zarf](https://github.com/zarf-dev/zarf) | minor |
`v0.37.0` -> `v0.38.1` |

---

### Release Notes

<details>
<summary>zarf-dev/zarf (zarf-dev/zarf)</summary>

###
[`v0.38.1`](https://github.com/zarf-dev/zarf/compare/v0.38.0...v0.38.1)

[Compare
Source](https://github.com/zarf-dev/zarf/compare/v0.38.0...v0.38.1)

### [`v0.38.0`](https://github.com/zarf-dev/zarf/releases/tag/v0.38.0)

[Compare
Source](https://github.com/zarf-dev/zarf/compare/v0.37.0...v0.38.0)

#### What's Changed

- refactor: utilize invopop comment feature by
[@&#8203;AustinAbro321](https://github.com/AustinAbro321) in
[zarf-dev/zarf#2781
- fix: detect invalid helm release names by
[@&#8203;jamestexas](https://github.com/jamestexas) in
[zarf-dev/zarf#2784
- refactor: move gitea code to separate package by
[@&#8203;phillebaba](https://github.com/phillebaba) in
[zarf-dev/zarf#2785
- fix: add dependabot and disable renovate features by
[@&#8203;AustinAbro321](https://github.com/AustinAbro321) in
[zarf-dev/zarf#2789
- chore(deps): bump github/codeql-action from 3.24.0 to 3.25.15 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2792
- chore(deps): bump actions/upload-artifact from 4.3.1 to 4.3.4 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2791
- chore(deps): bump golangci/golangci-lint-action from 6.0.1 to 6.1.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2793
- chore(deps): bump docker/login-action from 3.0.0 to 3.3.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2794
- chore(deps): bump ossf/scorecard-action from 2.3.1 to 2.4.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2795
- chore(deps): bump k8s.io/component-base from 0.30.0 to 0.30.3 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2798
- ci: remove unneeded cve checking by
[@&#8203;AustinAbro321](https://github.com/AustinAbro321) in
[zarf-dev/zarf#2802
- chore(deps): bump github.com/mikefarah/yq/v4 from 4.43.1 to 4.44.2 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2799
- chore(deps): bump codecov/codecov-action from 4.4.1 to 4.5.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2808
- chore(deps): bump actions/create-github-app-token from 1.9.0 to 1.10.3
by [@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2809
- chore(deps): bump actions/download-artifact from 4.1.2 to 4.1.8 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2810
- chore(deps): bump actions/checkout from 4.1.1 to 4.1.7 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2807
- chore(deps): bump golang.org/x/crypto from 0.24.0 to 0.25.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2813
- chore(deps): bump github.com/goccy/go-yaml from 1.11.3 to 1.12.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2811
- chore(deps): bump aws-actions/configure-aws-credentials from 4.0.1 to
4.0.2 by [@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2806
- fix: resolve CVE-2024-41110 by
[@&#8203;AustinAbro321](https://github.com/AustinAbro321) in
[zarf-dev/zarf#2815
- refactor: git package by
[@&#8203;phillebaba](https://github.com/phillebaba) in
[zarf-dev/zarf#2790
- ci: better named gh jobs by
[@&#8203;AustinAbro321](https://github.com/AustinAbro321) in
[zarf-dev/zarf#2816
- chore(deps): bump actions/dependency-review-action from 4.1.3 to 4.3.4
by [@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2822
- chore(deps): bump actions/setup-node from 4.0.2 to 4.0.3 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2821
- chore: move context.TODO to context.Background() (4) by
[@&#8203;schristoff](https://github.com/schristoff) in
[zarf-dev/zarf#2749
- chore(deps): bump
github.com/sigstore/sigstore/pkg/signature/kms/hashivault from 1.8.1 to
1.8.7 by [@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2800
- chore: turn down codecov by
[@&#8203;schristoff](https://github.com/schristoff) in
[zarf-dev/zarf#2823
- chore(deps): bump github.com/sigstore/sigstore/pkg/signature/kms/gcp
from 1.8.1 to 1.8.7 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2812
- refactor: move and test HasImages by
[@&#8203;phillebaba](https://github.com/phillebaba) in
[zarf-dev/zarf#2831
- fix: disk pressure flakes by
[@&#8203;AustinAbro321](https://github.com/AustinAbro321) in
[zarf-dev/zarf#2832
- chore(deps): bump actions/upload-artifact from 4.3.4 to 4.3.5 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2834
- refactor: change isInternal variables to functions by
[@&#8203;AustinAbro321](https://github.com/AustinAbro321) in
[zarf-dev/zarf#2768
- chore: update obsolete versions by
[@&#8203;AustinAbro321](https://github.com/AustinAbro321) in
[zarf-dev/zarf#2830
- refactor: init zarf state by
[@&#8203;AustinAbro321](https://github.com/AustinAbro321) in
[zarf-dev/zarf#2833
- fix: ignore config file not found errors by
[@&#8203;AustinAbro321](https://github.com/AustinAbro321) in
[zarf-dev/zarf#2838
- fix: override tunnel details with user-provided settings by
[@&#8203;chaospuppy](https://github.com/chaospuppy) in
[zarf-dev/zarf#2841
- refactor: move package generation to a local variable by
[@&#8203;phillebaba](https://github.com/phillebaba) in
[zarf-dev/zarf#2835
- feat: move ZarfPackageConfig to it's own api-versioned package by
[@&#8203;AustinAbro321](https://github.com/AustinAbro321) in
[zarf-dev/zarf#2801
- refactor: replace debug logs with returning errors by
[@&#8203;phillebaba](https://github.com/phillebaba) in
[zarf-dev/zarf#2777
- refactor: proxy and add tests by
[@&#8203;phillebaba](https://github.com/phillebaba) in
[zarf-dev/zarf#2843
- chore(deps): bump github/codeql-action from 3.25.15 to 3.26.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2848
- chore(deps): bump actions/upload-artifact from 4.3.5 to 4.3.6 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2847
- test: add tests for FindImages by
[@&#8203;phillebaba](https://github.com/phillebaba) in
[zarf-dev/zarf#2850
- test: unit test index sha by
[@&#8203;AustinAbro321](https://github.com/AustinAbro321) in
[zarf-dev/zarf#2844
- chore(deps): bump github.com/spf13/viper from 1.18.2 to 1.19.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2828
- chore: update dos games by
[@&#8203;AustinAbro321](https://github.com/AustinAbro321) in
[zarf-dev/zarf#2845
- chore(deps): bump sigs.k8s.io/kustomize/api from 0.16.0 to 0.17.3 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2826
- chore(deps): bump github.com/pterm/pterm from 0.12.78 to 0.12.79 by
[@&#8203;dependabot](https://github.com/dependabot) in
[zarf-dev/zarf#2854
- fix: install grype during release by
[@&#8203;phillebaba](https://github.com/phillebaba) in
[zarf-dev/zarf#2857
- fix: import paths to avoid cycle by
[@&#8203;phillebaba](https://github.com/phillebaba) in
[zarf-dev/zarf#2861

#### New Contributors

- [@&#8203;jamestexas](https://github.com/jamestexas) made their first
contribution in
[zarf-dev/zarf#2784

**Full Changelog**:
zarf-dev/zarf@v0.37.0...v0.38.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/defenseunicorns/uds-core).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM4LjIwLjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants