refactor: move finding table printing to CLI #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
|
I have removed the severity filter because I do not think it is being used. When calling Additionally we should start returning an exit code 1 for linter warnings. It should be up to the user to explicitly ignore this if they do not want to. |
phillebaba
force-pushed
the
fix/move-finding-table
branch
from
7568cd7
to
73cf9de
Compare
Codecov ReportAttention: Patch coverage is
|
phillebaba
force-pushed
the
fix/move-finding-table
branch
3 times, most recently
from
cb29862
to
3313708
Compare
Signed-off-by: Philip Laine <philip.laine@gmail.com>
phillebaba
force-pushed
the
fix/move-finding-table
branch
from
3313708
to
37ebe1c
Compare
AustinAbro321
requested changes
Sep 3, 2024
AustinAbro321
approved these changes
Sep 3, 2024
mjnagel
added a commit
to defenseunicorns/uds-core
that referenced
this pull request
Sep 5, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | ghcr.io/zarf-dev/packages/init | minor | `v0.38.3` -> `v0.39.0` | | [zarf-dev/zarf](https://redirect.github.com/zarf-dev/zarf) | minor | `v0.38.3` -> `v0.39.0` | --- ### Release Notes <details> <summary>zarf-dev/zarf (zarf-dev/zarf)</summary> ### [`v0.39.0`](https://redirect.github.com/zarf-dev/zarf/releases/tag/v0.39.0) [Compare Source](https://redirect.github.com/zarf-dev/zarf/compare/v0.38.3...v0.39.0) ##### What's Changed - chore: update dos games release by [@​AustinAbro321](https://redirect.github.com/AustinAbro321) in [zarf-dev/zarf#2921 - ci: id-token write application packages by [@​AustinAbro321](https://redirect.github.com/AustinAbro321) in [zarf-dev/zarf#2923 - docs: update dos games example by [@​AustinAbro321](https://redirect.github.com/AustinAbro321) in [zarf-dev/zarf#2924 - chore(deps): bump github/codeql-action from 3.26.4 to 3.26.5 by [@​dependabot](https://redirect.github.com/dependabot) in [zarf-dev/zarf#2927 - chore: schema adr by [@​AustinAbro321](https://redirect.github.com/AustinAbro321) in [zarf-dev/zarf#2600 - fix: remove use of pkg/errors by [@​phillebaba](https://redirect.github.com/phillebaba) in [zarf-dev/zarf#2937 - refactor: remove use of named returns in packager by [@​phillebaba](https://redirect.github.com/phillebaba) in [zarf-dev/zarf#2940 - chore(deps): bump github/codeql-action from 3.26.5 to 3.26.6 by [@​dependabot](https://redirect.github.com/dependabot) in [zarf-dev/zarf#2948 - refactor: remove printing available Helm charts and versions when the Chart is not found by [@​phillebaba](https://redirect.github.com/phillebaba) in [zarf-dev/zarf#2944 - refactor: remove connect strings from packager property by [@​phillebaba](https://redirect.github.com/phillebaba) in [zarf-dev/zarf#2941 - fix(ci): test-imports workflow breaks when called from a fork by [@​AustinAbro321](https://redirect.github.com/AustinAbro321) in [zarf-dev/zarf#2946 - feat: add health checks by [@​phillebaba](https://redirect.github.com/phillebaba) in [zarf-dev/zarf#2678 - refactor: move finding table printing to CLI by [@​phillebaba](https://redirect.github.com/phillebaba) in [zarf-dev/zarf#2960 - docs: update docs item in update Q2 roadmap by [@​eknowles](https://redirect.github.com/eknowles) in [zarf-dev/zarf#2958 - chore(deps): bump actions/upload-artifact from 4.3.6 to 4.4.0 by [@​dependabot](https://redirect.github.com/dependabot) in [zarf-dev/zarf#2957 - fix: progress bar image name flashes on push by [@​AustinAbro321](https://redirect.github.com/AustinAbro321) in [zarf-dev/zarf#2965 ##### New Contributors - [@​eknowles](https://redirect.github.com/eknowles) made their first contribution in [zarf-dev/zarf#2958 **Full Changelog**: zarf-dev/zarf@v0.38.3...v0.39.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change moves printing of the findings table from linting to the CLI rather than in the pkg code.
Related Issue
Relates to #2576
Checklist before merging