Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CODE_OF_CONDCUT.md file from the Zarr-Python repo #1572

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

MSanKeys963
Copy link
Member

@MSanKeys963 MSanKeys963 commented Nov 20, 2023

Hi everyone! 👋🏻

This PR updates the CoC to the same version as in here.

As discussed in #1572 (comment), I've removed the CODE_OF_CONDUCT.md from the Zarr-Python repository.

Please see zarr-developers/.github#2 for more details. Thanks!

TODO:

  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Nov 20, 2023
@jhamman
Copy link
Member

jhamman commented Nov 20, 2023

Q: do we need to duplicate this document in the Zarr-Python repo? Wont the parent organizations CoC apply here?

@MSanKeys963
Copy link
Member Author

Q: do we need to duplicate this document in the Zarr-Python repo? Wont the parent organizations CoC apply here?

Good point, @jhamman. I don't mind using the organisation-wide CoC for Zarr-Python and other repositories.
It's just that I happened to see the COC document in here and thought of syncing it.

@joshmoore
Copy link
Member

@MSanKeys963
Copy link
Member Author

Thanks, @joshmoore.

Just noticed https://github.com/zarr-developers/numcodecs/blob/main/CODE_OF_CONDUCT.md could use updating, too. 😉

I've already added zarr-developers/numcodecs#488 for this. ^

@joshmoore
Copy link
Member

But wasn't @jhamman's point that these files might not need to be duplicated across multiple repos?

@MSanKeys963
Copy link
Member Author

MSanKeys963 commented Nov 28, 2023

Yes. I think we need to make a decision for this.

If we're going to use the organisation-wide CoC across all repositories - I'll update the PR and remove the CoC from the Zarr-Python repo.

@jhamman
Copy link
Member

jhamman commented Nov 28, 2023

We already have the org-wide CoC: https://github.com/zarr-developers/.github/blob/main/CODE_OF_CONDUCT.md

So full support on removing this doc here. GitHub will pick the org-wide CoC up in all repositories that don't have their own.

@MSanKeys963
Copy link
Member Author

Thanks, @jhamman.

Updated this and zarr-developers/numcodecs#488.

@joshmoore
Copy link
Member

Thanks, guys.

@joshmoore joshmoore merged commit d40bf12 into zarr-developers:main Nov 29, 2023
21 checks passed
@MSanKeys963 MSanKeys963 changed the title Update CoC to the latest version Remove CODE_OF_CONDCUT.md file from Zarr-Python repo Dec 27, 2023
@MSanKeys963 MSanKeys963 changed the title Remove CODE_OF_CONDCUT.md file from Zarr-Python repo Remove CODE_OF_CONDCUT.md file from the Zarr-Python repo Dec 27, 2023
@MSanKeys963 MSanKeys963 deleted the update_coc branch December 27, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants