Add typing to dimension separator arguments #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1620 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 38 38
Lines 14574 14580 +6
=======================================
+ Hits 14573 14579 +6
Misses 1 1
|
d-v-b
approved these changes
Jan 9, 2024
|
thank you! I love the typing train |
|
Is there anything more I need to do here before this can be merged? |
d-v-b
reviewed
Feb 27, 2024
| @@ -2073,6 +2083,7 @@ def __init__( | |||
| self.mode = mode | |||
| self.open = open | |||
| self.write_lock = write_lock | |||
| self.write_mutex: Union[Lock, NoLock] | |||
There was a problem hiding this comment.
this is not a blocker, but we should look into making NoLock an instance of Lock
|
it looks good to me! unless anyone objects, I'm going to hit the merge button later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not very exciting, but carrys on the typing train. This PR adds typing to wherever a dimension separator argument is used in functions/methods.
TODO: