Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing attributes key from metadata, and other fixes #2058

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Jul 29, 2024

  • handle creating v3 metadata from a dict without an attributes key (attributes will be set to None in the resulting metadata document).
  • handle null entries in dimension_names correctly at validation
  • ensure that collection types become tuple during metadata serialization
  • make a copy of the input dict in from_dict method of array v3 metadata, to avoid mutating the input dict
  • allow creating ChunkKeyEncoding from dicts without configuration, because it's optional.
  • add a test case that revealed the problems fixed by all of the above changes.

closes #2024

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

…es elements, ensure that collections in metadata are tuples
@d-v-b d-v-b requested review from normanrz and jhamman July 29, 2024 22:11
@d-v-b
Copy link
Contributor Author

d-v-b commented Jul 30, 2024

thanks for looking over it @normanrz!

@d-v-b d-v-b merged commit 0e18671 into zarr-developers:v3 Jul 30, 2024
24 checks passed
@d-v-b d-v-b deleted the allow_null_attributes_redux branch July 30, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow null attributes
2 participants