Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate N5Store #2103

Merged
merged 8 commits into from
Aug 26, 2024
Merged

Deprecate N5Store #2103

merged 8 commits into from
Aug 26, 2024

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Aug 20, 2024

closed #2085

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jhamman jhamman changed the base branch from v3 to main August 20, 2024 03:08
@jhamman jhamman added this to the 2.18.3 milestone Aug 20, 2024
@jhamman jhamman added the V3 Related to compatibility with V3 spec label Aug 20, 2024
@jhamman jhamman changed the title Dep/n5 Deprecate N5Store Aug 20, 2024
@jhamman jhamman closed this Aug 20, 2024
@jhamman jhamman reopened this Aug 20, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (d1b92b5) to head (27b800e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2103   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files          38       38           
  Lines       14714    14718    +4     
=======================================
+ Hits        14712    14716    +4     
  Misses          2        2           
Files Coverage Δ
zarr/n5.py 100.00% <100.00%> (ø)

@jhamman jhamman requested a review from d-v-b August 26, 2024 18:35
@d-v-b
Copy link
Contributor

d-v-b commented Aug 26, 2024

We should get the same warning in for N5FSStore, happy to do that myself as needed

@jhamman
Copy link
Member Author

jhamman commented Aug 26, 2024

We should get the same warning in for N5FSStore, happy to do that myself as needed

I did it :)

@jhamman jhamman merged commit 2e928b1 into zarr-developers:main Aug 26, 2024
16 checks passed
This was referenced Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V3 Related to compatibility with V3 spec
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

deprecate n5
3 participants