-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default zarr.open to open_group if shape is not provided #2158
Open
agoodm
wants to merge
9
commits into
zarr-developers:v3
Choose a base branch
from
agoodm:v3_open_group
base: v3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+75
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamman
reviewed
Sep 10, 2024
agoodm
force-pushed
the
v3_open_group
branch
from
September 10, 2024 19:26
7408104
to
8af66e7
Compare
agoodm
commented
Sep 10, 2024
jhamman
reviewed
Sep 13, 2024
jni
pushed a commit
to napari/napari
that referenced
this pull request
Sep 16, 2024
# References and relevant issues closes #7270 # Description as zarr-developers/zarr-python#2143 is not resolved yet we need to block next alpha release. But there is zarr-developers/zarr-python#2158 opened, so it should be resolved shortly.
jhamman
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @agoodm -- thanks for working out the logic in a clean way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Description of PR] Closes #2143
This change makes the v3
zarr.open
more consistent with v2 by defaulting toopen_group
ifshape
isn't provided, which now allows for initializing a group in a non-existent path ifmode="a"
.TODO: