refactor: split metadata into v2 and v3 modules #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 12, 2024
dcherian
added a commit
to dcherian/zarr-python
that referenced
this pull request
Sep 16, 2024
* v3: fix: opening a group with unspecified format finds either v2 or v3 (zarr-developers#2183) test: check that store, array, and group classes are serializable (zarr-developers#2006) feature(store): V3 ZipStore (zarr-developers#2078) More typing fixes for tests (zarr-developers#2173) refactor: split metadata into v2 and v3 modules (zarr-developers#2163) Accept dictionaries for `store` argument (zarr-developers#2164) Simplify mypy config for tests (zarr-developers#2156) Fixed path segment duplication in open_array (zarr-developers#2167) Fixed test warnings (zarr-developers#2168) chore: update pre-commit hooks (zarr-developers#2165) Ensure that store_dict used for empty dicts (zarr-developers#2162) Bump pypa/gh-action-pypi-publish from 1.10.0 to 1.10.1 in the actions group (zarr-developers#2160)
dstansby
pushed a commit
to dstansby/zarr-python
that referenced
this pull request
Sep 17, 2024
* refactor: split metadata into v2 and v3 modules * add more explicit typeguards * port fill value normalization from v2 * remove v2 suffix from zarr format parsing * remove v2 suffix from zarr format parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A clean re-implementation of #2059.
metadata.pyintometadata/common.py,metadata/v2.py, andmetadata/v3.py_v2or_v3suffix that adorned quite a few parsing functions.ArrayV3MetadataandArrayV2Metadatafrommetadata. This might also be a good time to reconsider the names of those two classes, if anyone is bothered by them (ArrayMetadataV2, orV2ArrayMetadatacould seem a bit more logical thanArrayV2Metadata).TODO: