Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devtools: Detect more key formats with zcash-inspect #1537

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Sep 11, 2024

No description provided.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 181 lines in your changes missing coverage. Please review.

Project coverage is 60.61%. Comparing base (e7abed3) to head (c25cca0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
devtools/src/bin/inspect/keys/view.rs 0.00% 109 Missing ⚠️
devtools/src/bin/inspect/keys.rs 0.00% 52 Missing ⚠️
devtools/src/bin/inspect/main.rs 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1537      +/-   ##
==========================================
- Coverage   61.26%   60.61%   -0.65%     
==========================================
  Files         146      147       +1     
  Lines       16890    17071     +181     
==========================================
  Hits        10347    10347              
- Misses       6543     6724     +181     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nuttycom
nuttycom previously approved these changes Sep 11, 2024
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@str4d
Copy link
Contributor Author

str4d commented Sep 11, 2024

Force-pushed to fix compilation with zfuture.

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

@str4d str4d merged commit 6c3cc18 into main Sep 11, 2024
26 of 28 checks passed
@str4d str4d deleted the devtools-keys branch September 11, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants