Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(planner/elixir): Add Elixir support #93

Merged
merged 1 commit into from
Jun 25, 2023
Merged

feat(planner/elixir): Add Elixir support #93

merged 1 commit into from
Jun 25, 2023

Conversation

Charlie-117
Copy link
Contributor

  • supports Phoenix, Ecto apps

closes #44

@MichaelYuhe MichaelYuhe added gssoc enhancement New feature or request labels Jun 21, 2023
pan93412
pan93412 requested changes Jun 21, 2023
View reviewed changes
internal/elixir/identify.go Outdated
Comment on lines 28 to 41
ElixirVer, err := DetermineElixirVersion(options.Source)
if err != nil {
panic(err)
}

ElixirEcto, err := CheckElixirEcto(options.Source)
if err != nil {
panic(err)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to not panic() when something wrong. Seems like we need to re-design the API? cc @aFlyBird0

internal/elixir/plan.go Outdated Show resolved Hide resolved
internal/elixir/templates/template.Dockerfile Outdated Show resolved Hide resolved
@itsalicelee
Copy link
Contributor

@Charlie-117 Thanks for your contribution!
Just try out the official phoenix template, it worked but didn't show the framework information.
image
image1

@Charlie-117 Charlie-117 force-pushed the elixir_patch branch 2 times, most recently from b1d7990 to b4b6a63 Compare June 22, 2023 10:53
@Charlie-117
feat(planner/elixir): Add Elixir support
fa58fe5 
* supports Elixir, Phoenix, Ecto apps
@Charlie-117
Copy link
Contributor Author

@Charlie-117 Thanks for your contribution! Just try out the official phoenix template, it worked but didn't show the framework information. image image1

Earlier the commit only supported Phoenix framework so I didn't think of showing the framework's name but now I have tried to add support for regular Elixir apps along with Phoenix framework.

It now displays the framework name if present (Phoenix only for now).

pan93412
pan93412 approved these changes Jun 24, 2023
View reviewed changes
Copy link
Collaborator

@pan93412 pan93412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@Charlie-117
Copy link
Contributor Author

@MichaelYuhe Can you please add gssoc23 and level2 labels ? Thanks.

@pan93412 pan93412 added gssoc23 level2 for GSSoC 2023, temporarily labels Jun 24, 2023
@MichaelYuhe MichaelYuhe merged commit 0bbfa56 into zeabur:main Jun 25, 2023
4 checks passed
@MichaelYuhe
Copy link
Member

Thanks for your contribution!

hackerchai pushed a commit to hackerchai/zbpack that referenced this pull request Oct 29, 2023
@MichaelYuhe
Merge pull request zeabur#93 from Charlie-117/elixir_patch
d1b32bb 
feat(planner/elixir): Add Elixir support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan93412 pan93412 pan93412 approved these changes

@MichaelYuhe MichaelYuhe Awaiting requested review from MichaelYuhe

Assignees

@Charlie-117 Charlie-117

Labels
enhancement New feature or request gssoc gssoc23 level2 for GSSoC 2023, temporarily
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

elixir support
4 participants
@Charlie-117 @itsalicelee @MichaelYuhe @pan93412