Fix text transformation commands for multiple line, single selection cases #3060
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you highlight the following block of text (with a single selection):
and run
editor: convert to upper camel case
, you'll get:instead of:
The same thing happens for
editor: convert to title case
. This happens becauseto_case
crate doesn't allow the user to define '\n' as a boundary. I wanted to fix this at the lib level, so I filled an issue but I never heard back. What's strange is VS Code and Sublime I think both exhibit the same output as we do currently, but I don't personally think this feels right (happy to hear opposing opinions). I'm just doing the naive thing to hack around this limitation of theto_case
crate.I did some testing and it seems I only need to adjust
editor: convert to title case
andeditor: convert to upper camel case
. The way the other transformations are implemented into_case
don't seem to have this issue.Release Notes: