Standardized the request params initialization #81
Conversation
Forward port zendframework#67
Forward port zendframework#65
Forward port zendframework#75
… by following naming conventions Added an optional parameter --ignore-conventions | -i to avoid naming conventions A lot of refatoring for the CreateController
|
@RalfEggert I'm sorry for monstrous delay! Can you give me status update on that ? |
|
Actually, due to the lack of feedback on this pull request, I cloned ZFTool some time ago and started implementing all the features I needed on my own clone: https://github.com/RalfEggert/FrilleZFTool I did a lot of heavy rework on the whole tool and I am afraid it will be quite hard to integrate all this back into the original ZFTool. Then during the time I lost the focus on it. Anyway I have some plans for a whole new cli tool for the ZF. ZFTool is quite hard to maintain and extend, so a proper base might make more sense than a rewrite. |
|
Interesting. Could you elaborate on that? How is it hard to maintain? It's just a bunch of controllers and routes... |
|
Well, I tried to extends it but it needs a lot of refactoring . Just look at this controller. It is a bowl of spaghetti-code stuffed into a controller. https://github.com/zendframework/ZFTool/blob/master/src/ZFTool/Controller/CreateController.php Then for example this controller is rebuilding the classmap_generator.php Just two examples. |
|
Blame @ezimuel ;-)) Enrico ^ thoughts ? |
The parameters for module, controller and action were build up in every action and were implemented with some inconsistencies. This PR tidies up and implements standardized request parameters for all action methods in the CreateController. These parameters now follow the ZF2 coding standards:
http://framework.zend.com/wiki/display/ZFDEV2/Coding+Standards
For users who do not want to follow these coding standards an optional parameter was introduced. If the users adds "--ignore-conventions" or "-i" at the end of the "create module", "create controller", and "create action" command the coding stanards are ignored to give more flexibility.
In addition the code is generated with Zend\Code\Generator and adds DocBlocks skeletons. Also the CreateController was tidied up a little to follow ZF2 coding standards.