This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Provide negative unit-test for Issue #81 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Abstract-Container. Worked in 2.7.x, fails on 2.8.0
This patch adds a new private member, `$defaultValue`, to the `AbstractContainer`. `offsetGet()` now returns that member in the case that the provided `$key` is not a valid offset. This resolves the issue of returning a _reference_.
|
@MatthiasKuehneEllerhold I've pushed a fix to your branch; if Travis goes green, I'll merge for an immediate release. Thanks for your patience! |
weierophinney
added a commit
that referenced
this pull request
Jan 31, 2018
weierophinney
added a commit
that referenced
this pull request
Jan 31, 2018
Forward port #102 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a testcase for retrieving a value of a non-existing key from the AbstractContainer.
This worked in 2.7.x, but fails on 2.8.0.