This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Allow PHPunit 6.5+ when zend-session gets installed as dependency #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
approved these changes
Feb 13, 2018
|
@Koopzington I can't see that issue. What version of composer are you using? Just tested on local with composer 1.6.3 and I am able to install phpunit 6.5+ with zend-session 2.8.4 (latest release). |
michalbundyra
approved these changes
Feb 13, 2018
There was a problem hiding this comment.
@Koopzington sorry, my mistake, zend-session 2.8.2 has been installed in that case.
LGTM 👍
Ocramius
added a commit
that referenced
this pull request
Feb 22, 2018
Ocramius
added a commit
that referenced
this pull request
Feb 22, 2018
…flict Signed-off-by: Marco Pivetta <ocramius@gmail.com>
|
Also added to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c323a94 introduced a
conflictto the composer.json in order for builds to work. Unfortunately due to the nature ofconflictthis resulted in people not being able install phpunit >=6.5.0 when zend-session is being installed as dependency in a project.I therefore propose to update the
require-devline for phpunit to define a version range which will still ensure that travis builds of zend-session won't install any phpunit version >=6.5.0 and simultanously allows users that require zend-session as dependency in their projects to use newer versions.