This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Added ability to specify port #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -225,6 +228,9 @@ public function connect() | |||
| if (isset($hostname)) { | |||
| $dsn[] = "host={$hostname}"; | |||
| } | |||
| if (isset($port)) { | |||
| $dsn[] = "port={$port}"; | |||
There was a problem hiding this comment.
Please move the variable out of the quotes:
$dsn[] = "port=" . $port;
There was a problem hiding this comment.
@Freeaqingme that would conflict with the standards found here http://framework.zend.com/wiki/display/ZFDEV2/Coding+Standards#CodingStandards-VariableSubstitution and is inconsistent with the preceding block.
|
@radnan Thank you for your pull request. Could you please add a unit test for this? |
ghost
assigned 
This was referenced Feb 6, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.